Skip to content

[bugfix] Fix parsing of completion time of Slurm jobs #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2020
Merged

[bugfix] Fix parsing of completion time of Slurm jobs #1359

merged 2 commits into from
Jun 3, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jun 3, 2020

Fixes #1349

@teojgo teojgo requested review from ekouts and vkarak June 3, 2020 14:17
@teojgo teojgo self-assigned this Jun 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020 •
edited
Loading

Codecov Report

Merging #1359 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   91.65%   91.61%   -0.04%     
==========================================
  Files          83       83              
  Lines       12595    12600       +5     
==========================================
  Hits        11544    11544              
- Misses       1051     1056       +5
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 55.29% <0.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f59055...0c30bb1. Read the comment docs.

ekouts
ekouts approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak added this to the ReFrame sprint 20.08 milestone Jun 3, 2020
@vkarak vkarak merged commit f8bde58 into reframe-hpc:master Jun 3, 2020
@teojgo teojgo deleted the bugfix/parse_slurm_completion_time branch June 26, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@ekouts ekouts ekouts approved these changes

Assignees

@teojgo teojgo

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.08

Development

Successfully merging this pull request may close these issues.

ReFrame crashes when trying to retrieve the completion time of a Slurm job

4 participants

@teojgo @codecov-commenter @vkarak @ekouts