-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Add bootstrap script to install dependencies of ReFrame #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This allows to run ReFrame out-of-the-box using a single preparation step: ``` ./bootstrap.sh ./bin/reframe -l ``` No need for Python virtual environments.
Codecov Report
@@ Coverage Diff @@
## master #1371 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 83 83
Lines 12675 12675
=======================================
Hits 11618 11618
Misses 1057 1057 Continue to review full report at Codecov.
|
|
To test this PR, start from an empty virtual environment, so that ReFrame cannot find any of its dependencies, in case you have already installed them. |
…to feat/immediate-install
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have an option to pass the python interpreter to use? For example on my system I have both python3.6, python3.8.
|
@teojgo That should be possible, but I will need to separate where I install the external dependencies, e.g., |
You can have the default python command as |
|
@teojgo The |
It's ok. The problem is when you have an alternative installation of python on your system that the standard python3. But I believe this is specific to my local installation where I have to make the differentiation. Otherwise it's fine. |
|
@teojgo From our offline discussion I understood what you actually want and I'm gonna do it. |
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vkarak it works for all my python installations now.
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This really facilitates the processes of getting ready to run when you clone ReFrame from Github. You need only to do
or
This will
pip installall the dependencies inside the ReFrame source directory underexternal/. ReFrame's main "binaries" are adapted to look into this directory first for their dependencies. This solution does not preclude any of the other installation methods.Fixes #1365.
Still to do: