Skip to content

Conversation

@kraushm
Copy link
Contributor

@kraushm kraushm commented Jun 22, 2020

Changes to configuration and tests to include new PEs on Tsa/Arolla.

@pep8speaks
Copy link

pep8speaks commented Jun 22, 2020

Hello @kraushm, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-06-26 09:31:28 UTC

Correct for pep8speaks message
@vkarak vkarak changed the title [tsa] Tsa/validation mch pe20.06 [test] Update configuration and tests for MCH system Jun 22, 2020
@vkarak vkarak self-requested a review June 22, 2020 13:17
@kraushm
Copy link
Contributor Author

kraushm commented Jun 23, 2020

@jenkins-cscs retry all

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #1384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1384   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files          83       83           
  Lines       12712    12712           
=======================================
  Hits        11664    11664           
  Misses       1048     1048           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09de540...0d9f895. Read the comment docs.

@vkarak vkarak added this to the ReFrame sprint 20.10 milestone Jun 25, 2020
@victorusu
Copy link
Contributor

@kraushm, I agree with @vkarak's comments.

@victorusu victorusu self-requested a review June 25, 2020 09:37
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add arolla

@vkarak vkarak requested a review from victorusu June 26, 2020 20:03
@vkarak
Copy link
Contributor

vkarak commented Jun 27, 2020

@jenkins-cscs retry daint

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit aebe450 into reframe-hpc:master Jun 30, 2020
@kraushm kraushm deleted the tsa/validation_MCH-PE20.06 branch June 30, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants