Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jul 6, 2020

Fixes #1379.
Fixes UES-913.

@vkarak vkarak added this to the ReFrame sprint 20.10 milestone Jul 6, 2020
@vkarak vkarak requested review from ekouts and teojgo July 6, 2020 21:47
@vkarak vkarak self-assigned this Jul 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1399 into master will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
+ Coverage   91.46%   91.77%   +0.31%     
==========================================
  Files          83       83              
  Lines       12277    12708     +431     
==========================================
+ Hits        11229    11663     +434     
+ Misses       1048     1045       -3     
Impacted Files Coverage Δ
reframe/frontend/cli.py 78.81% <100.00%> (+0.66%) ⬆️
reframe/utility/color.py 100.00% <0.00%> (ø)
reframe/core/containers.py 100.00% <0.00%> (ø)
unittests/test_argparser.py 100.00% <0.00%> (ø)
unittests/test_check_filters.py 100.00% <0.00%> (ø)
unittests/test_sanity_functions.py 100.00% <0.00%> (ø)
...ittests/resources/checks_unlisted/kbd_interrupt.py 100.00% <0.00%> (ø)
unittests/test_deferrable.py 99.62% <0.00%> (+<0.01%) ⬆️
unittests/test_buildsystems.py 99.16% <0.00%> (+<0.01%) ⬆️
reframe/core/buildsystems.py 96.75% <0.00%> (+0.01%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5115365...7430d18. Read the comment docs.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit becd396 into reframe-hpc:master Jul 7, 2020
@vkarak vkarak deleted the bugfix/perflog-exec-modes branch July 7, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging does not take into account execution mode options

3 participants