Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jul 11, 2020

Requires #1410.
Fixes #1369.

@vkarak vkarak added this to the ReFrame sprint 20.11 milestone Jul 11, 2020
@vkarak vkarak requested a review from teojgo July 11, 2020 18:28
@vkarak vkarak self-assigned this Jul 11, 2020
@vkarak vkarak marked this pull request as draft July 11, 2020 18:29
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2020

Codecov Report

Merging #1411 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
- Coverage   91.79%   91.78%   -0.01%     
==========================================
  Files          82       82              
  Lines       12712    12716       +4     
==========================================
+ Hits        11669    11672       +3     
- Misses       1043     1044       +1     
Impacted Files Coverage Δ
unittests/fixtures.py 81.48% <100.00%> (+0.34%) ⬆️
unittests/test_argparser.py 100.00% <100.00%> (ø)
reframe/core/pipeline.py 92.71% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f77b29...90510f2. Read the comment docs.

@vkarak vkarak marked this pull request as ready for review July 13, 2020 12:17
@vkarak
Copy link
Contributor Author

vkarak commented Jul 13, 2020

The only change in this PR is that I've wrapped the runtime modifications in a with rt.temp_runtime(fixtures.BUILTIN_CONFIG_FILE): that creates a temporary runtime, so that these unit tests do not mess with the default runtime. The diff is larger due to the new indentation...

@vkarak vkarak merged commit 18f3b31 into reframe-hpc:master Jul 13, 2020
@vkarak vkarak deleted the bugfix/kbd-interrupt-failure branch July 13, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random failure of the test_kbd_interrupt_in_wait_with_limited_concurrency unit test

3 participants