Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jul 14, 2020

I am not doing any special post processing of the values retrieved, since they are well formed strings that you can nicely compare:

if cray_cle_info().release >= '7.0.UP00' and cray_cle_info().patchset < '09':
    # do sth

@vkarak vkarak added this to the ReFrame sprint 20.11 milestone Jul 14, 2020
@vkarak vkarak requested review from teojgo and victorusu July 14, 2020 15:58
@vkarak vkarak self-assigned this Jul 14, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #1419 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
+ Coverage   91.81%   91.83%   +0.02%     
==========================================
  Files          82       82              
  Lines       12750    12786      +36     
==========================================
+ Hits        11706    11742      +36     
  Misses       1044     1044              
Impacted Files Coverage Δ
reframe/utility/os_ext.py 91.06% <100.00%> (+0.52%) ⬆️
unittests/test_utility.py 99.73% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8497135...d4da331. Read the comment docs.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 38c65db into reframe-hpc:master Jul 14, 2020
@vkarak vkarak deleted the feat/cray-os-utility branch July 14, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants