Skip to content

[bugfix] Use '&' to combine Slurm constraints #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2020
Merged

[bugfix] Use '&' to combine Slurm constraints #1423

merged 3 commits into from
Jul 16, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jul 16, 2020

  • Adapt unittests, docs and the related regression checks.

Use '&' to combine slurm constraints
f0c9a58 
* Adapt unittests, docs and the related regression checks.
@teojgo teojgo added this to the ReFrame sprint 20.11 milestone Jul 16, 2020
@teojgo teojgo requested review from ekouts and vkarak July 16, 2020 07:39
@teojgo teojgo self-assigned this Jul 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #1423 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          82       82           
  Lines       12786    12786           
=======================================
  Hits        11742    11742           
  Misses       1044     1044
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 57.54% <100.00%> (ø)
unittests/test_schedulers.py 93.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c33e2...8e37f74. Read the comment docs.

@vkarak vkarak changed the title [bugfix] Use '&' to combine slurm constraints [bugfix] Use '&' to combine Slurm constraints Jul 16, 2020
vkarak
vkarak approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

victorusu
victorusu approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 7a7f956 into reframe-hpc:master Jul 16, 2020
@teojgo teojgo deleted the bugfix/use_and_constraint_combine branch October 23, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

@ekouts ekouts Awaiting requested review from ekouts

Assignees

@teojgo teojgo

Labels

bugfix prio: important

Projects

None yet

Milestone

ReFrame sprint 20.11

Development

Successfully merging this pull request may close these issues.

4 participants

@teojgo @codecov-commenter @vkarak @victorusu