Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jul 19, 2020

  • Also rename RFM_GRAYLOG_SERVER to RFM_GRAYLOG_ADDRESS for symmetry. RFM_GRAYLOG_SERVER is now deprecated.

Fixes #1056.

- Also rename ``RFM_GRAYLOG_SERVER`` to ``RFM_GRAYLOG_ADDRESS`` for symmetry.
@vkarak vkarak added this to the ReFrame sprint 20.11 milestone Jul 19, 2020
@vkarak vkarak requested review from teojgo and victorusu July 19, 2020 21:27
@vkarak vkarak self-assigned this Jul 19, 2020
@vkarak vkarak changed the title [feat] Allow Syslog's address to be set from an environment variable. [feat] Allow Syslog's address to be set from an environment variable Jul 19, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2020

Codecov Report

Merging #1427 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.02%     
==========================================
  Files          82       82              
  Lines       12794    12798       +4     
==========================================
+ Hits        11751    11753       +2     
- Misses       1043     1045       +2     
Impacted Files Coverage Δ
reframe/frontend/cli.py 78.52% <50.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d8f22...0b1e253. Read the comment docs.

@vkarak
Copy link
Contributor Author

vkarak commented Jul 20, 2020

@bcfriesen This allows you to set the Syslog address through an environment variable. It's not exactly what's discussed in #1056, but I think it serves the same purpose. You can set this variable dynamically based on where ReFrame is run.

@vkarak vkarak merged commit 2ab91d3 into reframe-hpc:master Jul 21, 2020
@vkarak vkarak deleted the feat/syslog-addr-envvar branch July 21, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Syslog and Graylog handlers to dynamically set the address and port of the remote host

3 participants