-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Support multiple tags in extract* sanity functions
#1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Support also passing of multiple conversion functions for each tag to be extracted.
|
@vkarak Does this cover our case? If yes I will also add the documentation. |
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
+ Coverage 91.83% 91.93% +0.10%
==========================================
Files 82 82
Lines 12798 12959 +161
==========================================
+ Hits 11753 11914 +161
Misses 1045 1045
Continue to review full report at Codecov.
|
|
@teojgo We will also need to update the documentation. |
Yes I wanted first to see if what I thought about the tag/conv function was correct. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two very minor things still.
extract* sanity functions
each tag to be extracted.
Fixes #1245