Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jul 23, 2020

  • Support also passing of multiple conversion functions for
    each tag to be extracted.

Fixes #1245

* Support also passing of multiple conversion functions for
  each tag to be extracted.
@teojgo teojgo added this to the ReFrame sprint 20.11 milestone Jul 23, 2020
@teojgo teojgo requested review from victorusu and vkarak July 23, 2020 11:49
@teojgo teojgo self-assigned this Jul 23, 2020
@teojgo
Copy link
Contributor Author

teojgo commented Jul 23, 2020

@vkarak Does this cover our case? If yes I will also add the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #1433 into master will increase coverage by 0.10%.
The diff coverage is 90.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   91.83%   91.93%   +0.10%     
==========================================
  Files          82       82              
  Lines       12798    12959     +161     
==========================================
+ Hits        11753    11914     +161     
  Misses       1045     1045              
Impacted Files Coverage Δ
reframe/utility/sanity.py 97.45% <82.92%> (-1.50%) ⬇️
unittests/test_sanity_functions.py 100.00% <100.00%> (ø)
reframe/core/pipeline.py 92.56% <0.00%> (-0.15%) ⬇️
reframe/frontend/executors/policies.py 98.23% <0.00%> (+0.01%) ⬆️
unittests/test_policies.py 98.71% <0.00%> (+0.05%) ⬆️
unittests/test_cli.py 90.97% <0.00%> (+0.16%) ⬆️
reframe/frontend/cli.py 79.44% <0.00%> (+0.91%) ⬆️
reframe/frontend/statistics.py 95.62% <0.00%> (+4.02%) ⬆️
reframe/core/exceptions.py 90.07% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c027bc7...5c53575. Read the comment docs.

@vkarak vkarak marked this pull request as ready for review July 23, 2020 14:21
@vkarak
Copy link
Contributor

vkarak commented Jul 23, 2020

@teojgo We will also need to update the documentation.

@teojgo
Copy link
Contributor Author

teojgo commented Jul 23, 2020

@teojgo We will also need to update the documentation.

Yes I wanted first to see if what I thought about the tag/conv function was correct.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two very minor things still.

@vkarak vkarak changed the title [feat] Support multiple tags in extract* sanity functions [feat] Support multiple tags in extract* sanity functions Jul 24, 2020
@vkarak vkarak merged commit 46fbddd into reframe-hpc:master Jul 24, 2020
@teojgo teojgo deleted the feat/extractall_multiple branch October 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a sanity function for extracting multiple capturing groups at a time

3 participants