Skip to content

[bugfix] Fix JSON schema $id parameter #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

[bugfix] Fix JSON schema $id parameter #1438

merged 1 commit into from
Jul 28, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jul 27, 2020

Fixes #1436

@teojgo teojgo requested a review from victorusu July 27, 2020 12:25
@teojgo teojgo self-assigned this Jul 27, 2020
@teojgo teojgo changed the title [bugfix] Fix json schema $id parameter [bugfix] Fix JSON schema $id parameter Jul 27, 2020
vkarak
vkarak approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teojgo
Copy link
Contributor Author

teojgo commented Jul 28, 2020

@jenkins-cscs retry tsa

@teojgo teojgo merged commit 0a4dc52 into reframe-hpc:master Jul 28, 2020
@teojgo teojgo deleted the bugfix/json_schema_ids branch July 28, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@teojgo teojgo

Labels

bugfix prio: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

$id parameter in JSON schemas is wrong

2 participants

@teojgo @vkarak