-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Fix parsing of multiline exec_host in qstat output
#1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Fix parsing of multiline exec_host in qstat output
#1457
Conversation
The exec_host field in the qstat output may span multiple lines as the number of compute nodes gets larger, like this: exec_host = r26i13n04/0-35+r26i13n07/0-35+r26i13n19/0-35+r25i13n15/0-35+r2 5i13n18/0-35+r25i27n03/0-35+r25i27n04/0-35+r25i27n05/0-35+r25i27n07/0- 35+r25i27n08/0-35+r25i27n10/0-35+r25i27n11/0-35+r25i27n23/0-35 Before this commit, only the first line would be parsed, and hence the node list would be incomplete at best.
|
Hello @MaximeVdB, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-08-21 11:12:19 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
- Coverage 91.93% 91.92% -0.01%
==========================================
Files 82 82
Lines 12959 12960 +1
==========================================
Hits 11914 11914
- Misses 1045 1046 +1
Continue to review full report at Codecov.
|
|
Can I test this patch? |
|
ok to test |
|
@MaximeVdB ignore my previous comment. I was just talking to the internal CI :-) |
|
Hi @vkarak -- is there something more I need to do? |
|
Hi @MaximeVdB, looks good, I will merge it. Thanks for submitting this patch! |
|
@jenkins-cscs retry daint |
exec_host in qstat output
Hi ! In Torque-managed jobs, the exec_host field in the qstat output may span multiple
lines as the number of compute nodes gets larger, like this:
Before this commit, only the first line would be parsed, and hence the node list would be incomplete at best.
I have tried out this fix on a 10-node job and it works as expected.
I briefly looked into adding a unit test for this, but that does not seem straightforward in this case?