Skip to content

Conversation

@MaximeVdB
Copy link
Contributor

Hi ! In Torque-managed jobs, the exec_host field in the qstat output may span multiple
lines as the number of compute nodes gets larger, like this:

exec_host = r26i13n04/0-35+r26i13n07/0-35+r26i13n19/0-35+r25i13n15/0-35+r2<linebreak>
<tab>5i13n18/0-35+r25i27n03/0-35+r25i27n04/0-35+r25i27n05/0-35+r25i27n07/0-<linebreak>
<tab>35+r25i27n08/0-35+r25i27n10/0-35+r25i27n11/0-35+r25i27n23/0-35

Before this commit, only the first line would be parsed, and hence the node list would be incomplete at best.
I have tried out this fix on a 10-node job and it works as expected.

I briefly looked into adding a unit test for this, but that does not seem straightforward in this case?

The exec_host field in the qstat output may span multiple
lines as the number of compute nodes gets larger, like this:

exec_host = r26i13n04/0-35+r26i13n07/0-35+r26i13n19/0-35+r25i13n15/0-35+r2
   5i13n18/0-35+r25i27n03/0-35+r25i27n04/0-35+r25i27n05/0-35+r25i27n07/0-
   35+r25i27n08/0-35+r25i27n10/0-35+r25i27n11/0-35+r25i27n23/0-35

Before this commit, only the first line would be parsed,
and hence the node list would be incomplete at best.
@pep8speaks
Copy link

pep8speaks commented Aug 20, 2020

Hello @MaximeVdB, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-08-21 11:12:19 UTC

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #1457 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
- Coverage   91.93%   91.92%   -0.01%     
==========================================
  Files          82       82              
  Lines       12959    12960       +1     
==========================================
  Hits        11914    11914              
- Misses       1045     1046       +1     
Impacted Files Coverage Δ
reframe/core/schedulers/torque.py 26.78% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8ac90...3194e47. Read the comment docs.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@vkarak
Copy link
Contributor

vkarak commented Aug 21, 2020

ok to test

@vkarak
Copy link
Contributor

vkarak commented Aug 21, 2020

@MaximeVdB ignore my previous comment. I was just talking to the internal CI :-)

@MaximeVdB
Copy link
Contributor Author

Hi @vkarak -- is there something more I need to do?
That change request seems moot, since you took care of it, right?

@vkarak
Copy link
Contributor

vkarak commented Aug 21, 2020

Hi @MaximeVdB, looks good, I will merge it. Thanks for submitting this patch!

@vkarak
Copy link
Contributor

vkarak commented Aug 21, 2020

@jenkins-cscs retry daint

@vkarak vkarak changed the title [bugfix] Fix parsing of multiline exec_host in qstat output [bugfix] Fix parsing of multiline exec_host in qstat output Aug 21, 2020
@vkarak vkarak merged commit 576eb3f into reframe-hpc:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants