[bugfix] Fix crash when git is not available #1472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Catch the exception thrown in case git is not installed * Add a unittest
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
=======================================
Coverage 91.71% 91.72%
=======================================
Files 82 82
Lines 12922 12924 +2
=======================================
+ Hits 11852 11854 +2
Misses 1070 1070
Continue to review full report at Codecov.
|
vkarak
requested changes
Sep 4, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Just a minor style comment.
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch the exception thrown in case git is not installed
Add a unittest
Fixes #1464