[feat] Drop support of scheduler-specific command-line options #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rsarm, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-09-22 08:21:55 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1483 +/- ##
==========================================
+ Coverage 91.72% 91.73% +0.01%
==========================================
Files 83 83
Lines 12954 12886 -68
==========================================
- Hits 11882 11821 -61
+ Misses 1072 1065 -7
Continue to review full report at Codecov.
|
ekouts
requested changes
Sep 16, 2020
vkarak
requested changes
Sep 18, 2020
vkarak
approved these changes
Sep 19, 2020
Contributor
|
@jenkins-cscs retry all |
ekouts
requested changes
Sep 21, 2020
Contributor
ekouts
left a comment
ekouts
left a comment
There was a problem hiding this comment.
Sorry, but I just realized that there are also parts in the documentation that have to be removed. For example we still have the option --partition in the man pages.
ekouts
approved these changes
Sep 22, 2020
Contributor
|
@jenkins-cscs retry tsa |
vkarak
changed the title
sched_* internal variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1368 and #1354