[bugfix] Fix JSON report generation for deferred expressions #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a custom 'json' utility package which uses the `__rfm_json_encode__` method for json encoding if defined. * Implement the above method for `_Deferred_Expression` objects. * Add unittests for the custom `json` utility package.
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
+ Coverage 91.71% 91.72% +0.01%
==========================================
Files 82 83 +1
Lines 12928 12959 +31
==========================================
+ Hits 11857 11887 +30
- Misses 1071 1072 +1
Continue to review full report at Codecov.
|
vkarak
changed the title
json utility package for object dumping
vkarak
requested changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom 'json' utility package which uses the
__rfm_json_encode__method for json encoding if defined.Implement the above method for
_Deferred_Expressionobjects.Add unittests for the custom
jsonutility package.Fixes #1459