Add regression tests for GPU direct. #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ajocksch I am changing the title of this PR, because the major contribution are the GPU direct tests, which is cool! |
vkarak
requested changes
Mar 1, 2018
cscs-checks/prgenv/openacc_checks.py
Outdated
| def __init__(self, **kwargs): | ||
| super().__init__('openacc_fortran_check', | ||
| def __init__(self, num_tasks, **kwargs): | ||
| if (num_tasks == 1): |
Contributor
There was a problem hiding this comment.
Please remove parentheses here.
cscs-checks/prgenv/openacc_checks.py
Outdated
| self._pgi_flags = '-acc -ta=tesla:cc35' | ||
|
|
||
| self.num_tasks = num_tasks | ||
| if (self.num_tasks == 1): |
Contributor
There was a problem hiding this comment.
Please remove parentheses here.
| import os | ||
|
|
||
| from reframe.core.pipeline import RegressionTest | ||
| import reframe.utility.sanity as sn |
Contributor
There was a problem hiding this comment.
Please swap these two statements.
| import os | ||
|
|
||
| from reframe.core.pipeline import RegressionTest | ||
| import reframe.utility.sanity as sn |
Contributor
There was a problem hiding this comment.
Please swap these two statements.
| import reframe.utility.sanity as sn | ||
| from reframe.core.pipeline import RegressionTest | ||
|
|
||
| import reframe.utility.sanity as sn |
Contributor
There was a problem hiding this comment.
The imports must be as follows:
import os
import reframe.utility.sanity as sn
from reframe.core.pipeline import RegressionTest| from reframe.core.pipeline import RegressionTest | ||
| import reframe.utility.sanity as sn | ||
|
|
||
| class GpuDirectCudaCheck(RegressionTest): |
Contributor
There was a problem hiding this comment.
I think this test should go under cuda/.
Contributor
|
@ajocksch Do you think you can manage this for this sprint? |
Contributor
|
@ajocksch The |
vkarak
approved these changes
Mar 6, 2018
Contributor
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrgEnv-pgion Kesch.Fixes #86.