Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Sep 26, 2020

Fixes #1485.

@vkarak vkarak added this to the ReFrame sprint 20.14 milestone Sep 26, 2020
@vkarak vkarak requested review from teojgo and victorusu September 26, 2020 21:08
@vkarak vkarak self-assigned this Sep 26, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1501 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1501   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files          83       83           
  Lines       12993    13002    +9     
=======================================
+ Hits        11898    11907    +9     
  Misses       1095     1095           
Impacted Files Coverage Δ
reframe/core/runtime.py 94.33% <100.00%> (+0.07%) ⬆️
unittests/test_environments.py 73.12% <100.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb8596...22bedf6. Read the comment docs.

@vkarak vkarak merged commit c8d5ed5 into reframe-hpc:master Sep 28, 2020
@vkarak vkarak deleted the bugfix/module-fail-restore-env branch September 28, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame may not restore the environment correctly if a module load has failed in previous test

3 participants