Skip to content

Conversation

@victorusu
Copy link
Contributor

While working on the improved spack recipe for ReFrame, I got the following error:

==> Installing py-pip
...
==> Installing reframe
...
$ ml reframe
$ reframe -l
Traceback (most recent call last):
  File "/users/hvictor/spack-victor/opt/spack/linux-centos8-broadwell/gcc-8.3.1/reframe-bootstrap-z2zqkak5qb5kepxr2p4pyryrbck4ma2c/external/jsonschema/__init__.py", line 31, in <module>
    from importlib import metadata
ImportError: cannot import name 'metadata'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/users/hvictor/spack-victor/opt/spack/linux-centos8-broadwell/gcc-8.3.1/reframe-bootstrap-z2zqkak5qb5kepxr2p4pyryrbck4ma2c/bin/reframe", line 18, in <module>
    import reframe.frontend.cli as cli  # noqa: F401, F403
  File "/users/hvictor/spack-victor/opt/spack/linux-centos8-broadwell/gcc-8.3.1/reframe-bootstrap-z2zqkak5qb5kepxr2p4pyryrbck4ma2c/reframe/__init__.py", line 26, in <module>
    from reframe.core.pipeline import *     # noqa: F401, F403
  File "/users/hvictor/spack-victor/opt/spack/linux-centos8-broadwell/gcc-8.3.1/reframe-bootstrap-z2zqkak5qb5kepxr2p4pyryrbck4ma2c/reframe/core/pipeline.py", line 26, in <module>
    import reframe.core.runtime as rt
  File "/users/hvictor/spack-victor/opt/spack/linux-centos8-broadwell/gcc-8.3.1/reframe-bootstrap-z2zqkak5qb5kepxr2p4pyryrbck4ma2c/reframe/core/runtime.py", line 14, in <module>
    import reframe.core.config as config
  File "/users/hvictor/spack-victor/opt/spack/linux-centos8-broadwell/gcc-8.3.1/reframe-bootstrap-z2zqkak5qb5kepxr2p4pyryrbck4ma2c/reframe/core/config.py", line 10, in <module>
    import jsonschema
  File "/users/hvictor/spack-victor/opt/spack/linux-centos8-broadwell/gcc-8.3.1/reframe-bootstrap-z2zqkak5qb5kepxr2p4pyryrbck4ma2c/external/jsonschema/__init__.py", line 33, in <module>
    import importlib_metadata as metadata

@victorusu victorusu self-assigned this Oct 1, 2020
@victorusu victorusu requested review from teojgo and vkarak October 1, 2020 14:32
@vkarak vkarak changed the title [bug] Add importlib_metadata to requirements [bugfix] Add importlib_metadata to requirements Oct 1, 2020
@vkarak vkarak added this to the ReFrame sprint 20.14 milestone Oct 1, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #1503 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files          83       83           
  Lines       13012    13012           
=======================================
  Hits        11926    11926           
  Misses       1086     1086           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8f324...1ea9353. Read the comment docs.

@vkarak vkarak changed the title [bugfix] Add importlib_metadata to requirements [bugfix] Add importlib_metadata to requirements Oct 1, 2020
@vkarak vkarak merged commit f8889c9 into reframe-hpc:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants