[feat] Delay the setup of performance logging, so that perf_patterns can be defined after the test construction
#1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jenkins-cscs retry all |
Contributor
Author
|
@jenkins-cscs daint |
1 similar comment
Contributor
Author
|
@jenkins-cscs daint |
vkarak
changed the title
perf_patterns can be defined after the init method
vkarak
changed the title
perf_patterns can be defined after the init methodperf_patterns can be defined after the test construction
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
+ Coverage 91.45% 91.55% +0.09%
==========================================
Files 83 83
Lines 13222 13223 +1
==========================================
+ Hits 12092 12106 +14
+ Misses 1130 1117 -13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1376 .
I tested it with @jgphpc 's example and it works.