Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Oct 7, 2020

Fixes #1408 .

@ekouts ekouts added this to the ReFrame sprint 20.14 milestone Oct 7, 2020
@ekouts ekouts requested a review from vkarak October 7, 2020 13:36
@ekouts ekouts self-assigned this Oct 7, 2020
@ekouts
Copy link
Contributor Author

ekouts commented Oct 8, 2020

@jenkins-cscs retry all

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Remove redundant information in error message when a sane Tmod installation cannot be found [bugfix] Fix error message when a sane Tmod installation cannot be found Oct 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #1510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1510   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files          83       83           
  Lines       13223    13223           
=======================================
  Hits        12106    12106           
  Misses       1117     1117           
Impacted Files Coverage Δ
reframe/core/modules.py 60.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609d330...98c5c79. Read the comment docs.

@vkarak vkarak merged commit 09ee169 into reframe-hpc:master Oct 8, 2020
@ekouts ekouts deleted the bugfix/redundant_error_message branch October 8, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant information in error message when a sane Tmod installation cannot be found

4 participants