Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Oct 7, 2020

Fixes #1511.

This PR also addresses the following:

  • Fix System JSON representation
  • Adjust sleep times in local scheduler unit tests

Vasileios Karakasis added 2 commits October 7, 2020 21:23
- Fix `System` JSON representation
- Adjust sleep times in local scheduler unit tests
@vkarak vkarak added this to the ReFrame sprint 20.14 milestone Oct 7, 2020
@vkarak vkarak requested a review from ekouts October 7, 2020 21:29
@vkarak vkarak self-assigned this Oct 7, 2020
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #1513 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   91.51%   91.55%   +0.03%     
==========================================
  Files          83       83              
  Lines       13198    13224      +26     
==========================================
+ Hits        12078    12107      +29     
+ Misses       1120     1117       -3     
Impacted Files Coverage Δ
reframe/core/systems.py 88.31% <ø> (ø)
reframe/frontend/executors/__init__.py 98.69% <100.00%> (+<0.01%) ⬆️
reframe/frontend/executors/policies.py 99.32% <100.00%> (+0.03%) ⬆️
unittests/test_cli.py 91.13% <100.00%> (+0.16%) ⬆️
unittests/test_policies.py 99.50% <100.00%> (+<0.01%) ⬆️
unittests/test_schedulers.py 94.25% <100.00%> (ø)
reframe/core/schedulers/slurm.py 54.03% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099789b...7657dc6. Read the comment docs.

@vkarak vkarak merged commit c123779 into reframe-hpc:master Oct 8, 2020
@vkarak vkarak deleted the bugfix/force-local-crash branch October 8, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.local fails on slurm partition

4 participants