Skip to content

[bugfix] Fix typo in modules system unit tests #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2020
Merged

[bugfix] Fix typo in modules system unit tests #1517

merged 3 commits into from
Oct 8, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Oct 8, 2020

Fixes #1515

@teojgo teojgo requested a review from vkarak October 8, 2020 11:16
@teojgo teojgo self-assigned this Oct 8, 2020
@vkarak vkarak changed the title [bugfix] Fix typo in 'unittests/test_modules.py' [bugfix] Fix typo in modules system unit tests Oct 8, 2020
vkarak
vkarak requested changes Oct 8, 2020
View reviewed changes
victorusu
victorusu approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #1517 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
+ Coverage   91.45%   91.55%   +0.09%     
==========================================
  Files          83       83              
  Lines       13222    13224       +2     
==========================================
+ Hits        12092    12107      +15     
+ Misses       1130     1117      -13
Impacted Files Coverage Δ
unittests/test_modules.py 76.96% <100.00%> (ø)
reframe/frontend/executors/policies.py 99.32% <0.00%> (+<0.01%) ⬆️
reframe/utility/os_ext.py 91.91% <0.00%> (+5.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21eed48...7dafed1. Read the comment docs.

@vkarak vkarak merged commit 7ff0f6c into reframe-hpc:master Oct 8, 2020
@vkarak vkarak added this to the ReFrame sprint 20.14 milestone Oct 8, 2020
@teojgo teojgo deleted the bugfix/test_modules branch October 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

Assignees

@teojgo teojgo

Labels

bugfix code quality prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.14

Development

Successfully merging this pull request may close these issues.

Typo in module unit tests

4 participants

@teojgo @codecov-io @vkarak @victorusu