Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Oct 8, 2020

Fixes #1516

@teojgo teojgo requested a review from vkarak October 8, 2020 11:22
@teojgo teojgo self-assigned this Oct 8, 2020
@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #1518 into master will decrease coverage by 3.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
- Coverage   91.55%   87.90%   -3.65%     
==========================================
  Files          83       43      -40     
  Lines       13223     6839    -6384     
==========================================
- Hits        12106     6012    -6094     
+ Misses       1117      827     -290     
Impacted Files Coverage Δ
...s/resources/checks_unlisted/no_required_version.py
unittests/resources/checks/hellocheck.py
unittests/test_policies.py
unittests/test_argparser.py
...tests/resources/checks_unlisted/deprecated_test.py
unittests/test_shell.py
unittests/test_launchers.py
unittests/test_utility.py
...ittests/resources/checks_unlisted/kbd_interrupt.py
unittests/test_cli.py
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff0f6c...5c19d39. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak added this to the ReFrame sprint 20.14 milestone Oct 8, 2020
@vkarak vkarak changed the title [ci] Remove the unittests from the coverage report [ci] Remove the unit tests from the coverage report Oct 8, 2020
@vkarak vkarak merged commit d01b456 into reframe-hpc:master Oct 8, 2020
@teojgo teojgo deleted the ci/rm_unittests_coverage branch October 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not include unit test coverage in the coverage report

3 participants