[feat] Set the default location for log files to be the system's temporary directory #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2020 18:06
- Make `name` file log handler parameter optional that defaults to a temporary file.
vkarak
changed the title
teojgo
approved these changes
Oct 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #1531 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 43 43
Lines 6839 6848 +9
=======================================
+ Hits 6012 6020 +8
- Misses 827 828 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renders the
nameconfiguration parameter of thefilelog handler optional and sets the default location to be in the system's temporary directory. The behaviour of the framework with the current configuration files that set thenameparameter is not affected.Documentation and the tutorials are also updated.
This PR allows the parallelization of the unit tests as discussed in #134.
Fixes #1177.