-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Add ability to restore a test session and rerun selected tests #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add ability to restore a test session and rerun selected tests #1538
Conversation
|
Hello @rsarm, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-12-07 18:30:11 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
+ Coverage 87.57% 87.71% +0.14%
==========================================
Files 44 45 +1
Lines 7289 7475 +186
==========================================
+ Hits 6383 6557 +174
- Misses 906 918 +12
Continue to review full report at Codecov.
|
|
For a quick test: |
|
I think you should also add the |
|
@jenkins-cscs retry dom |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also need documentation.
|
Yesterday after adding the options |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's on the right track, but still needs some refinement and the dumping must go deeper. I will look closer into the test dumps, and you can work on the other comments.
- This brings along full restore capability for ReFrame tests.
Also: - Properly decode `tags` in `RegressionTest`
|
@jenkins-cscs retry dom |
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I have tested and it works fine. I have a slight comment only if you agree.
Closes #1222
EDIT @vkarak
This PR adds two new command-line options:
--restore-session [REPORT], which can restore a previous testing session from a report file and--failedto select the failed tests.To achieve the restoration of tests, it introduces a mechanism for serializing and deserializing arbitrary objects in JSON. Any class the derives from
JSONSerializablecan be encoded in JSON. If an attribute cannot be converted, it will be silently set tonull. The deserialization recreates the objects from the JSON contents and based on some additional metadata that contains the module file and the class name.Still todo:
RegressionTestRegressionTestattributes