-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Fix spacing issues when defining options for execution modes #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 44 44
Lines 6894 6897 +3
=======================================
+ Hits 6069 6072 +3
Misses 825 825
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I see the fix, I don't think that this was actually a bug, but rather the configuration was wrong. Nonetheless, this will prevent common user errors in the future. Apart from the rest of the comments, we will need to adjust the unit test configuration to exercise this. Simply change the following two lines:
https://github.com/eth-cscs/reframe/blob/master/unittests/resources/settings.py#L134-L135
to
'-c unittests/resources/checks/hellocheck.py',
'-p builtin-gcc',
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now
Fixes #1554