[feat] Add possibility to inherit the prefix from the parent class #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
+ Coverage 87.57% 87.61% +0.03%
==========================================
Files 45 45
Lines 7244 7249 +5
==========================================
+ Hits 6344 6351 +7
+ Misses 900 898 -2
Continue to review full report at Codecov.
|
vkarak
requested changes
Nov 3, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
We will need a unit test for this functionality.
|
Hello @jjotero, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-11-17 15:45:52 UTC |
Contributor
Author
Done. |
victorusu
changed the title
jjotero
changed the title
vkarak
requested changes
Nov 12, 2020
vkarak
approved these changes
Nov 17, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Lgtm. I'm going to push a couple of minor changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1569