-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Add support for module collections #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jgphpc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-11-09 16:55:22 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
- Coverage 87.99% 87.81% -0.19%
==========================================
Files 45 45
Lines 7016 7106 +90
==========================================
+ Hits 6174 6240 +66
- Misses 842 866 +24
Continue to review full report at Codecov.
|
|
@jenkins-cscs retry dom |
|
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, only the minor suggestions that I have made.
…nto feat/module-collections
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, only the minor suggestions that I have made.
This PR adds support for module collections for Lmod and Tmod4. Environment modules in the configuration can be defined with two alternative syntaxes: (a) simple strings as of now and (b) JSON objects with two attributes, the name of the module and whether this is a collection or not:
Implementation details
_SiteConfig.get()function will return that.modules_detailed, which returns the modules in their extended format; you can unpack them and pass them to the modules systems API._mlstatusfor indicating the exit status of module command.Fixes #1526.
Replaces #1537.