-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] List inherited pipeline hooks with the -L option
#1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is very close to this one:
I think we should have a class method that will iterate over the hooks walking through the mro. This will be used also in the place shown above.
|
@vkarak In the listing of the tests with |
I thought the same thing yesterday, but I don't have a strong opinion. For the moment I would say, whichever is the most straightforward to implement. |
Codecov Report
@@ Coverage Diff @@
## master #1597 +/- ##
==========================================
- Coverage 87.80% 87.62% -0.19%
==========================================
Files 45 45
Lines 7112 7258 +146
==========================================
+ Hits 6245 6360 +115
- Misses 867 898 +31
Continue to review full report at Codecov.
|
|
@jenkins-cscs retry dom |
Closes #1566.