Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Nov 13, 2020

Closes #1566.

@ekouts ekouts added this to the ReFrame sprint 20.17 milestone Nov 13, 2020
@ekouts ekouts requested review from teojgo and vkarak November 13, 2020 14:47
@ekouts ekouts self-assigned this Nov 13, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is very close to this one:

https://github.com/eth-cscs/reframe/blob/67e66aad96ae751186c2efa58d319f34b6a394ba/reframe/core/pipeline.py#L84

I think we should have a class method that will iterate over the hooks walking through the mro. This will be used also in the place shown above.

@ekouts
Copy link
Contributor Author

ekouts commented Nov 18, 2020

@vkarak In the listing of the tests with -L do we want to print disabled hooks as well?

@vkarak
Copy link
Contributor

vkarak commented Nov 18, 2020

@vkarak In the listing of the tests with -L do we want to print disabled hooks as well?

I thought the same thing yesterday, but I don't have a strong opinion. For the moment I would say, whichever is the most straightforward to implement.

@codecov-io
Copy link

Codecov Report

Merging #1597 (19ff896) into master (7ee99e8) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
- Coverage   87.80%   87.62%   -0.19%     
==========================================
  Files          45       45              
  Lines        7112     7258     +146     
==========================================
+ Hits         6245     6360     +115     
- Misses        867      898      +31     
Impacted Files Coverage Δ
reframe/frontend/cli.py 79.51% <ø> (-0.25%) ⬇️
reframe/core/pipeline.py 92.25% <100.00%> (+0.18%) ⬆️
reframe/utility/osext.py 84.71% <0.00%> (-7.86%) ⬇️
reframe/core/runtime.py 89.63% <0.00%> (-4.88%) ⬇️
reframe/frontend/executors/policies.py 99.33% <0.00%> (-0.01%) ⬇️
reframe/frontend/check_filters.py
reframe/frontend/filters.py 100.00% <0.00%> (ø)
reframe/utility/__init__.py 91.79% <0.00%> (+0.23%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee99e8...19ff896. Read the comment docs.

@vkarak
Copy link
Contributor

vkarak commented Nov 20, 2020

@jenkins-cscs retry dom

@vkarak vkarak merged commit 53de376 into reframe-hpc:master Nov 20, 2020
@ekouts ekouts deleted the bugfix/detailed_hooks branch November 23, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inherited pipeline hooks are not listed with the -L option

3 participants