[feat] Allow any test attribute to be logged #1600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
+ Coverage 87.81% 87.84% +0.02%
==========================================
Files 44 44
Lines 7241 7267 +26
==========================================
+ Hits 6359 6384 +25
- Misses 882 883 +1
Continue to review full report at Codecov.
|
vkarak
requested changes
Nov 18, 2020
ekouts
reviewed
Nov 20, 2020
vkarak
requested changes
Nov 20, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
The documentation must also be updated.
added 5 commits
November 21, 2020 13:50
- Remove the `log_extra` attribute. This is not needed, because if an attribute does not exist, it will be simply logged as `None`. So users can introduce any check attribute as a format specifier. - Add unit tests
- As well as format `None` and errors in a human-readable manner.
vkarak
approved these changes
Nov 21, 2020
vkarak
changed the title
Contributor
Contributor
Author
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: @vkarak
This PR adds the ability to log any test attribute. If the attribute cannot be found,
<undefined>will be logged instead. If an attribute is deferrable it will be evaluated and if this is not possible<error>will be logged.Fixes #1068.
Fixes #1432.