Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Nov 16, 2020

Closes #1414.

Example of output:

$ ./bin/reframe -c unittests/resources/checks_unlisted/deps_complex.py -r
...
==============================================================================
SUMMARY OF FAILURES
...
------------------------------------------------------------------------------
FAILURE INFO for T9
  * Test Description: T9
  * System partition: dom:mc
  * Environment: PrgEnv-intel
  * Stage directory: None
  * Node list: None
  * Job type: batch job (id=None)
  * Dependencies (conceptual): ['T8']
  * Dependencies (actual): [('T8', 'dom:mc', 'PrgEnv-intel')]
  * Maintainers: []
  * Failing phase: startup
  * Rerun with '-n T9 -p PrgEnv-intel --system dom:mc'
  * Reason: task dependency error: dependencies failed
------------------------------------------------------------------------------
FAILURE INFO for T9
  * Test Description: T9
  * System partition: dom:mc
  * Environment: PrgEnv-pgi
  * Stage directory: None
  * Node list: None
  * Job type: batch job (id=None)
  * Dependencies (conceptual): ['T8']
  * Dependencies (actual): [('T8', 'dom:mc', 'PrgEnv-pgi')]
  * Maintainers: []
  * Failing phase: startup
  * Rerun with '-n T9 -p PrgEnv-pgi --system dom:mc'
  * Reason: task dependency error: dependencies failed
...

@ekouts ekouts added this to the ReFrame sprint 20.17 milestone Nov 16, 2020
@ekouts ekouts requested review from rsarm and vkarak November 16, 2020 08:47
@ekouts ekouts self-assigned this Nov 16, 2020
@ekouts ekouts changed the title [feat] Print dependencies of tests in json report [feat] Print dependencies of tests in failure report Nov 16, 2020
@vkarak vkarak changed the title [feat] Print dependencies of tests in failure report [feat] Print test dependencies in failure report Nov 17, 2020
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also bump the data version of the report here:

https://github.com/eth-cscs/reframe/blob/044397958f6cc6eba0a5272cd26dbbb03c0959d8/reframe/frontend/cli.py#L597

The idea is to bump the data format minor version every time we do an incremental change and the major version every time there is a breaking change.

* Bump the data version of the report
* Rename dependencies_real to dependencies_actual
@pep8speaks
Copy link

pep8speaks commented Nov 18, 2020

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2020-11-18 09:25:43 UTC

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I only have a minor comment.

@vkarak vkarak merged commit a68f42f into reframe-hpc:master Nov 18, 2020
@ekouts ekouts deleted the feat/deps_in_report branch November 18, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print dependencies of tests in failure report

4 participants