[bugfix] Fix regression when filtering with multiple criteria #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
reviewed
Nov 16, 2020
ekouts
approved these changes
Nov 16, 2020
teojgo
approved these changes
Nov 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #1603 +/- ##
=======================================
Coverage 87.48% 87.48%
=======================================
Files 45 45
Lines 7127 7127
=======================================
Hits 6235 6235
Misses 892 892
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced with #1594 and it is a regression. I've added also a unit test to catch this in the future.