[feat] Add command-line option to manipulate the module path before executing any tests #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the corresponding documentation. * Add unittests.
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2020-11-23 19:08:33 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1606 +/- ##
==========================================
- Coverage 87.91% 87.66% -0.25%
==========================================
Files 44 44
Lines 7258 7283 +25
==========================================
+ Hits 6381 6385 +4
- Misses 877 898 +21
Continue to review full report at Codecov.
|
vkarak
requested changes
Nov 17, 2020
vkarak
requested changes
Nov 18, 2020
Contributor
|
Also I would expect the actions using the different modules systems to fail 🤔 |
vkarak
requested changes
Nov 19, 2020
vkarak
requested changes
Nov 23, 2020
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I have minor comments except that I don't understand why it is correct to exit with 1 in the test_unuse_module_path() test.
vkarak
reviewed
Nov 23, 2020
vkarak
approved these changes
Nov 23, 2020
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the corresponding documentation.
Add unittests.
Fixes #1395