Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Nov 18, 2020

Fixes #1607

@teojgo teojgo added this to the ReFrame sprint 20.17 milestone Nov 18, 2020
@teojgo teojgo requested review from victorusu and vkarak November 18, 2020 13:42
@teojgo teojgo self-assigned this Nov 18, 2020
@codecov-io
Copy link

codecov-io commented Nov 18, 2020

Codecov Report

Merging #1608 (a1b97b9) into master (1399785) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1608   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          45       45           
  Lines        7251     7251           
=======================================
  Hits         6353     6353           
  Misses        898      898           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1399785...a1b97b9. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is deeper. Check my comment.

@vkarak
Copy link
Contributor

vkarak commented Nov 18, 2020

The problem existed long ago, but it wasn't appearing... Since the container_platform uses the type attribute, this is treated specially when get() constructs the default key: it uses systems/partitions/container_platforms/Docker_modules instead of systems/partitions/container_platforms/modules, which is what we set as default key. The fix is simple, but in a completely different place :-)

diff --git a/reframe/schemas/config.json b/reframe/schemas/config.json
index 6fea2162..99fabceb 100644
--- a/reframe/schemas/config.json
+++ b/reframe/schemas/config.json
@@ -460,8 +460,8 @@
         "systems/partitions/access": [],
         "systems/partitions/environs": [],
         "systems/partitions/container_platforms": [],
-        "systems/partitions/container_platforms/modules": [],
-        "systems/partitions/container_platforms/variables": [],
+        "systems/partitions/container_platforms/*modules": [],
+        "systems/partitions/container_platforms/*variables": [],
         "systems/partitions/resources": [],
         "systems/partitions/resources/options": [],
         "systems/partitions/modules": [],

@vkarak vkarak changed the title [bugfix] Handle None argument in 'normalize_module_list' [bugfix] Properly define default values for the 'modules' and 'variables' configuration parameters of the 'container_platforms' Nov 18, 2020
@vkarak vkarak merged commit aac8146 into reframe-hpc:master Nov 18, 2020
@teojgo teojgo deleted the bugfix/normalize_modules_None branch November 25, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame crashes if container_platforms is defined without modules

3 participants