Skip to content

[refactor] Align implementations of the PBS and the Torque scheduler regarding the use of qstat #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 20, 2020
Merged

[refactor] Align implementations of the PBS and the Torque scheduler regarding the use of qstat #1612

merged 7 commits into from
Nov 20, 2020

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Nov 20, 2020

Closes #1563
Closes #1473

@ekouts ekouts added this to the ReFrame sprint 20.17 milestone Nov 20, 2020
@ekouts ekouts requested review from teojgo and vkarak November 20, 2020 07:47
@ekouts ekouts self-assigned this Nov 20, 2020
@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #1612 (330c7b4) into master (8b6a23f) will increase coverage by 0.16%.
The diff coverage is 5.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
+ Coverage   87.64%   87.81%   +0.16%     
==========================================
  Files          45       45              
  Lines        7255     7239      -16     
==========================================
- Hits         6359     6357       -2     
+ Misses        896      882      -14
Impacted Files Coverage Δ
reframe/core/schedulers/torque.py 100.00% <ø> (+80.59%) ⬆️
reframe/core/schedulers/pbs.py 46.85% <5.45%> (-17.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6a23f...330c7b4. Read the comment docs.

vkarak
vkarak requested changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

@vkarak vkarak changed the title [feat] Align implementations of the PBS and the Torque scheduler regarding the use of qstat [refactor] Align implementations of the PBS and the Torque scheduler regarding the use of qstat Nov 20, 2020
@vkarak vkarak merged commit dc7e2d8 into reframe-hpc:master Nov 20, 2020
@ekouts ekouts deleted the feat/align_pbs branch November 23, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@ekouts ekouts

Labels

code quality prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.17

Development

Successfully merging this pull request may close these issues.

Align implementations of the PBS and the Torque scheduler regarding the use of qstat Implement max_pending_time for the PBS scheduler

3 participants

@ekouts @codecov-io @vkarak