Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Nov 24, 2020

  • The SingleSource build system now raises an exception when
    it fails to guess the programming language of the source file.

  • Add unittests.

Fixes #1546

* The SingleSource build system now raises an exception when
it fails to guess the programming language of the source file.

* Add unittests.
@teojgo teojgo added this to the ReFrame sprint 20.18 milestone Nov 24, 2020
@teojgo teojgo requested review from ekouts and vkarak November 24, 2020 16:07
@teojgo teojgo self-assigned this Nov 24, 2020
@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #1619 (699899e) into master (e8f9253) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   87.66%   87.68%   +0.01%     
==========================================
  Files          44       44              
  Lines        7283     7283              
==========================================
+ Hits         6385     6386       +1     
+ Misses        898      897       -1     
Impacted Files Coverage Δ
reframe/core/buildsystems.py 97.47% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f9253...699899e. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is not so clear to me is how this was triggering the bug that we observed. Can you explain a bit?

@teojgo
Copy link
Contributor Author

teojgo commented Nov 25, 2020

What is not so clear to me is how this was triggering the bug that we observed. Can you explain a bit?

So in our case, even though the sourcepath was non existent, the build system did not raise the exception during autodetection. Therefore, no actual compilation/build command was generated and the compilation script did nothing so it was not failing.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak
Copy link
Contributor

vkarak commented Nov 28, 2020

@jenkins-cscs retry dom

@vkarak vkarak changed the title [bugfix] Fix SingleSource when guessing of language fails [bugfix] Fail properly when the source code language cannot be guessed Nov 28, 2020
@vkarak vkarak merged commit f2ab219 into reframe-hpc:master Nov 28, 2020
@teojgo teojgo deleted the bugfix/unknown_lang_singlesource branch December 2, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compilation phase passes if a non-existent path is passed in sourcepath

4 participants