-
Notifications
You must be signed in to change notification settings - Fork 117
[bugfix] Fail properly when the source code language cannot be guessed #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Fail properly when the source code language cannot be guessed #1619
Conversation
* The SingleSource build system now raises an exception when it fails to guess the programming language of the source file. * Add unittests.
Codecov Report
@@ Coverage Diff @@
## master #1619 +/- ##
==========================================
+ Coverage 87.66% 87.68% +0.01%
==========================================
Files 44 44
Lines 7283 7283
==========================================
+ Hits 6385 6386 +1
+ Misses 898 897 -1
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is not so clear to me is how this was triggering the bug that we observed. Can you explain a bit?
So in our case, even though the sourcepath was non existent, the build system did not raise the exception during autodetection. Therefore, no actual compilation/build command was generated and the compilation script did nothing so it was not failing. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@jenkins-cscs retry dom |
The SingleSource build system now raises an exception when
it fails to guess the programming language of the source file.
Add unittests.
Fixes #1546