Skip to content

[ci] Add Github action to check for unused imports #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2020
Merged

[ci] Add Github action to check for unused imports #1622

merged 4 commits into from
Nov 28, 2020

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Nov 26, 2020

Fixes #1557

@teojgo teojgo added this to the ReFrame sprint 20.18 milestone Nov 26, 2020
@teojgo teojgo requested review from victorusu and vkarak November 26, 2020 16:56
@teojgo teojgo self-assigned this Nov 26, 2020
@codecov-io
Copy link

codecov-io commented Nov 26, 2020 •
edited
Loading

Codecov Report

Merging #1622 (bc96bf3) into master (f2ab219) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage   87.68%   87.68%   -0.01%     
==========================================
  Files          44       44              
  Lines        7283     7281       -2     
==========================================
- Hits         6386     6384       -2     
  Misses        897      897
Impacted Files Coverage Δ
reframe/frontend/cli.py 76.63% <ø> (-0.06%) ⬇️
reframe/frontend/loader.py 92.50% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ab219...bc96bf3. Read the comment docs.

vkarak
vkarak approved these changes Nov 28, 2020
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vkarak vkarak merged commit a3942ab into reframe-hpc:master Nov 28, 2020
@teojgo teojgo deleted the ci/unused_imports branch December 2, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu Awaiting requested review from victorusu

Assignees

@teojgo teojgo

Labels

automation prio: normal

Projects

None yet

Milestone

ReFrame sprint 20.18

Development

Successfully merging this pull request may close these issues.

Check automatically for unused imports on pushes to open PRs

3 participants

@teojgo @codecov-io @vkarak