Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Dec 2, 2020

No description provided.

@teojgo teojgo added this to the ReFrame sprint 20.18 milestone Dec 2, 2020
@teojgo teojgo requested a review from vkarak December 2, 2020 07:55
@teojgo teojgo self-assigned this Dec 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #1635 (cfd3c3e) into master (26da6e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1635   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files          44       44           
  Lines        7292     7292           
=======================================
  Hits         6384     6384           
  Misses        908      908           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26da6e4...cfd3c3e. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but did you understand why it doesn't work?

@teojgo
Copy link
Contributor Author

teojgo commented Dec 2, 2020

Lgtm, but did you understand why it doesn't work?

Yes it would need to be in a separate workflow to work. But I don't think it offers anything since the ReFrame CI badge now includes also the linting.

@vkarak
Copy link
Contributor

vkarak commented Dec 2, 2020

@jenkins-cscs retry dom

@vkarak vkarak merged commit dbb5e91 into reframe-hpc:master Dec 2, 2020
@teojgo teojgo deleted the docs/remove_linter_badge branch December 2, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants