Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Dec 12, 2020

This PR introduces also a method for the module system backends that they can override in order to process the Python bindings output before executing the Python statements. We use this mechanism to fix the emitted Python commands from Lmod versions prior to 8.2, which are broken.

Fixes #1648.

@vkarak vkarak added this to the ReFrame sprint 20.19 milestone Dec 12, 2020
@vkarak vkarak requested review from teojgo and victorusu December 12, 2020 18:48
@vkarak vkarak self-assigned this Dec 12, 2020
@vkarak
Copy link
Contributor Author

vkarak commented Dec 12, 2020

@mand35 Can you test if this PR works for your system?

@codecov-io
Copy link

Codecov Report

Merging #1654 (05957e4) into master (4bf3156) will decrease coverage by 0.06%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1654      +/-   ##
==========================================
- Coverage   87.72%   87.65%   -0.07%     
==========================================
  Files          45       45              
  Lines        7477     7485       +8     
==========================================
+ Hits         6559     6561       +2     
- Misses        918      924       +6     
Impacted Files Coverage Δ
reframe/core/modules.py 58.89% <18.18%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf3156...05957e4. Read the comment docs.

@vkarak vkarak merged commit e1611cd into reframe-hpc:master Dec 14, 2020
@vkarak vkarak deleted the bugfix/lmod-crash-pre-82 branch December 14, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame 3.3 and above broke support for Lmod < 8.2

3 participants