-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Adapt GROMACS test to Eiger #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1657 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 45 45
Lines 7485 7485
=======================================
Hits 6561 6561
Misses 924 924 Continue to review full report at Codecov.
|
|
@jenkins-cscs retry eiger |
|
Hi @lucamar, can you remove the unused imports as indicated by this check? https://github.com/eth-cscs/reframe/pull/1657/checks?check_run_id=1551861788 |
|
@jenkins-cscs retry eiger |
|
I will update the pull request once #1658 is merged to fix the issue with parallel unittests on Eiger. |
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@jenkins-cscs retry eiger |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, too
|
@jenkins-cscs retry eiger |
GROMACS small and large check on Eiger: reference values are tentative as there might be room for improvement.