Skip to content

Conversation

@lucamar
Copy link
Contributor

@lucamar lucamar commented Dec 14, 2020

GROMACS small and large check on Eiger: reference values are tentative as there might be room for improvement.

@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #1657 (f23b965) into master (adb0d1d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1657   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files          45       45           
  Lines        7485     7485           
=======================================
  Hits         6561     6561           
  Misses        924      924           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb0d1d...f23b965. Read the comment docs.

@lucamar
Copy link
Contributor Author

lucamar commented Dec 14, 2020

@jenkins-cscs retry eiger

@vkarak
Copy link
Contributor

vkarak commented Dec 14, 2020

Hi @lucamar, can you remove the unused imports as indicated by this check? https://github.com/eth-cscs/reframe/pull/1657/checks?check_run_id=1551861788

@lucamar
Copy link
Contributor Author

lucamar commented Dec 14, 2020

@jenkins-cscs retry eiger

@lucamar
Copy link
Contributor Author

lucamar commented Dec 15, 2020

I will update the pull request once #1658 is merged to fix the issue with parallel unittests on Eiger.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucamar
Copy link
Contributor Author

lucamar commented Dec 15, 2020

@jenkins-cscs retry eiger

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, too

@lucamar
Copy link
Contributor Author

lucamar commented Dec 15, 2020

@jenkins-cscs retry eiger

@vkarak vkarak added this to the ReFrame sprint 20.19 milestone Dec 15, 2020
@vkarak vkarak changed the title [test] GROMACS on Eiger [test] Adapt GROMACS test to Eiger Dec 15, 2020
@vkarak vkarak merged commit e90017a into reframe-hpc:master Dec 15, 2020
@lucamar lucamar deleted the gromacs-eiger branch February 5, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants