Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Dec 20, 2020

We instead cache the last evaluated value and returned that one. If the deferred expression has never been evaluated, then None is returned.

This addresses #1646.

We instead cache the last evaluated value and returned that one. If the deferred
expression has never been evaluated, then `None` is returned.
@vkarak vkarak added this to the ReFrame sprint 20.19 milestone Dec 20, 2020
@vkarak vkarak requested review from ekouts and teojgo December 20, 2020 11:31
@vkarak vkarak self-assigned this Dec 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #1665 (1e13812) into master (01d7efc) will decrease coverage by 0.30%.
The diff coverage is 49.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
- Coverage   87.54%   87.23%   -0.31%     
==========================================
  Files          45       45              
  Lines        7492     7546      +54     
==========================================
+ Hits         6559     6583      +24     
- Misses        933      963      +30     
Impacted Files Coverage Δ
reframe/core/modules.py 56.62% <45.28%> (-1.21%) ⬇️
reframe/core/deferrable.py 97.56% <83.33%> (+0.01%) ⬆️
reframe/core/pipeline.py 92.32% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddadba...1e13812. Read the comment docs.

@vkarak vkarak requested a review from victorusu December 20, 2020 18:25
@vkarak vkarak merged commit 0d29dbf into reframe-hpc:master Dec 21, 2020
@vkarak vkarak deleted the bugfix/jsonext-dump-deferrable-no-eval branch December 21, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants