Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Jan 22, 2021

Second, much simpler implementation of #1672. In this PR the submission blocks until slurm stops giving the QOSMaxSubmitJobPerUserLimit error. This could cause significant slowdown of the jobs.
Closes #1595.

@ekouts ekouts added this to the ReFrame sprint 21.01 milestone Jan 22, 2021
@ekouts ekouts requested review from victorusu and vkarak January 22, 2021 08:15
@ekouts ekouts self-assigned this Jan 22, 2021
@pep8speaks
Copy link

pep8speaks commented Jan 22, 2021

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-02-01 20:22:12 UTC

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need documentation.

@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1704 (920593b) into master (391ef9e) will decrease coverage by 0.01%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
- Coverage   87.30%   87.29%   -0.02%     
==========================================
  Files          46       46              
  Lines        7649     7704      +55     
==========================================
+ Hits         6678     6725      +47     
- Misses        971      979       +8     
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 52.73% <10.00%> (-1.05%) ⬇️
reframe/frontend/statistics.py 95.31% <0.00%> (-1.41%) ⬇️
reframe/core/schedulers/local.py 95.79% <0.00%> (-0.07%) ⬇️
reframe/frontend/executors/__init__.py 98.19% <0.00%> (+0.09%) ⬆️
reframe/core/exceptions.py 94.20% <0.00%> (+0.12%) ⬆️
reframe/frontend/executors/policies.py 99.67% <0.00%> (+0.34%) ⬆️
reframe/core/shell.py 95.45% <0.00%> (+0.45%) ⬆️
reframe/frontend/cli.py 76.79% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391ef9e...920593b. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also do some minor adaptations to the documentation.

@vkarak vkarak force-pushed the feat/max_job_limit_blocking branch from 0c67c88 to e63c838 Compare February 1, 2021 20:18
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@vkarak vkarak merged commit 8dca540 into reframe-hpc:master Feb 1, 2021
@vkarak vkarak changed the title [feat] Support multiple job submissions when slurm's job submit limit is reached [feat] Retry job submission with Slurm on error conditions specified by the user Feb 1, 2021
@ekouts ekouts deleted the feat/max_job_limit_blocking branch February 2, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

job submit limits don't count other user jobs that may already be in the queue

4 participants