-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Retry job submission with Slurm on error conditions specified by the user #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Retry job submission with Slurm on error conditions specified by the user #1704
Conversation
|
Hello @ekouts, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-02-01 20:22:12 UTC |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also need documentation.
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
==========================================
- Coverage 87.30% 87.29% -0.02%
==========================================
Files 46 46
Lines 7649 7704 +55
==========================================
+ Hits 6678 6725 +47
- Misses 971 979 +8
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will also do some minor adaptations to the documentation.
0c67c88 to
e63c838
Compare
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine.
Second, much simpler implementation of #1672. In this PR the submission blocks until slurm stops giving the
QOSMaxSubmitJobPerUserLimiterror. This could cause significant slowdown of the jobs.Closes #1595.