Skip to content

[bugfix] Skip test cases recursively in case of dangling dependencies #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2021
Merged

[bugfix] Skip test cases recursively in case of dangling dependencies #1714

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfda43e
Skip test cases recursively in case of dangling dependencies
Jan 25, 2021
6bb9894
Merge branch 'master' into bugfix/skip-cases-dangling-deps
Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions reframe/frontend/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def resolve_dep(src, dst):
# c stands for check or case depending on the context
# p stands for partition
# e stands for environment
# t stands for target

# We use an ordered dict here, because we need to keep the order of
# partitions and environments
Expand All @@ -79,8 +78,23 @@ def resolve_dep(src, dst):
if when((psrc, esrc), (pdst, edst)):
c.deps.append(d)
except DependencyError as e:
getlogger().warning(f'{e}; skipping test case...')
skipped_cases.append(c)
getlogger().warning(f'{e}; skipping dependent test cases:')

# FIXME: we need to unit test this properly
skip_nodes = {c}
while skip_nodes:
v = skip_nodes.pop()
skipped_cases.append(v)
getlogger().warning(f' - {v}')
pruned_nodes = []
for u, adj in graph.items():
if v in adj:
skip_nodes.add(u)
pruned_nodes.append(u)

for u in pruned_nodes:
del graph[u]

continue

graph[c] = util.OrderedSet(c.deps)
Expand Down