Skip to content

[bugfix] Fix parameter value specification in the parameter() directive #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2021
Merged

[bugfix] Fix parameter value specification in the parameter() directive #1722

merged 2 commits into from
Jan 31, 2021

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Jan 29, 2021

On its current state, the parameters are specified in a class as

class Test(rfm.RegressionTest):
    parameter('P0', 1, 2, 3 , 4, 5)

This PR will change the parameter definition to

class Test(rfm.RegressionTest):
    parameter('P0', [1, 2, 3 , 4, 5])

@vkarak vkarak self-requested a review January 31, 2021 11:33
@vkarak vkarak added this to the ReFrame sprint 21.02 milestone Jan 31, 2021
vkarak
vkarak approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [bugfix] Specify parameter values with a list [bugfix] Fix parameter value specification in the parameter() directive Jan 31, 2021
@vkarak vkarak merged commit 7daa11c into reframe-hpc:master Jan 31, 2021
@jjotero jjotero deleted the feat/fix-param-values branch February 10, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

Assignees

@jjotero jjotero

Labels

bugfix prio: important

Projects

None yet

Milestone

ReFrame 3.4.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jjotero @vkarak