[test] Port QuantumESPRESSO checks to Eiger #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @lucamar, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-02-16 13:13:30 UTC |
ekouts
approved these changes
Feb 15, 2021
Contributor
ekouts
left a comment
ekouts
left a comment
There was a problem hiding this comment.
Lgtm in general, I have only a small comment.
Co-authored-by: ekouts <eirini.koutsaniti@cscs.ch>
vkarak
reviewed
Feb 15, 2021
Contributor
|
@jenkins-cscs retry eiger |
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
num_cpus_per_task=16andOMP_NUM_THREADS=8should yield a better performance with respect tonum_cpus_per_task=8and'OMP_NUM_THREADS': str(self.num_cpus_per_task).In order to improve a bit more the performance of the test, I have also added the Slurm directive
#SBATCH --distribution=block:blockand thesruncommand line option--cpu-bind=coresusing pipeline hooks.