[bugfix] Fix bug and parameterize cuda samples tests #1758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-02-11 15:15:49 UTC |
jjotero
suggested changes
Feb 9, 2021
Contributor
jjotero
left a comment
jjotero
left a comment
There was a problem hiding this comment.
Looks good! My only suggestion is that we start using the new parametrisation syntax instead.
Codecov Report
@@ Coverage Diff @@
## master #1758 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 47 47
Lines 7792 7792
=======================================
Hits 6807 6807
Misses 985 985 Continue to review full report at Codecov.
|
vkarak
requested changes
Feb 10, 2021
vkarak
requested changes
Feb 11, 2021
Contributor
|
@jenkins-cscs retry daint tsa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.