Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Feb 10, 2021

This PR also adds the following:

  • Expand deprecation message function to issue deprecation warnings in future releases.
  • Old style of version specification is set to deprecate in 3.5.0

TODO:

  • Update documentation of the @required_version decorator.

NOTE: The CI will fail due to an irrelevant reason. A separate PR will fix that (it's Gitlab CI lint failure)

Expand deprecation message function to issue deprecation warnings in future
releases.
@vkarak vkarak added this to the ReFrame 3.4.2 milestone Feb 10, 2021
@vkarak vkarak requested review from rsarm and teojgo February 10, 2021 12:38
@vkarak vkarak self-assigned this Feb 10, 2021
@vkarak vkarak changed the title [feat] Comply with the semantic versioning spec [feat] Comply with the semantic versioning specification Feb 10, 2021
@vkarak vkarak changed the title [feat] Comply with the semantic versioning specification [bugfix] Comply with the semantic versioning specification Feb 10, 2021
@vkarak vkarak changed the title [bugfix] Comply with the semantic versioning specification [feat] Comply with the semantic versioning specification Feb 10, 2021
@vkarak vkarak requested a review from teojgo February 15, 2021 17:08
@vkarak
Copy link
Contributor Author

vkarak commented Feb 16, 2021

@teojgo The wheelvalidation works ;-) I will fix the PR.

@codecov-io
Copy link

Codecov Report

Merging #1761 (78a6739) into master (6838342) will increase coverage by 0.00%.
The diff coverage is 97.82%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1761   +/-   ##
=======================================
  Coverage   87.35%   87.36%           
=======================================
  Files          47       47           
  Lines        7792     7765   -27     
=======================================
- Hits         6807     6784   -23     
+ Misses        985      981    -4     
Impacted Files Coverage Δ
reframe/utility/osext.py 84.71% <75.00%> (ø)
reframe/__init__.py 81.81% <100.00%> (ø)
reframe/core/decorators.py 97.08% <100.00%> (ø)
reframe/core/warnings.py 100.00% <100.00%> (ø)
reframe/frontend/runreport.py 92.55% <100.00%> (ø)
reframe/utility/versioning.py 96.77% <100.00%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6838342...78a6739. Read the comment docs.

@vkarak vkarak merged commit 026bc30 into reframe-hpc:master Feb 16, 2021
@vkarak vkarak deleted the feat/future-deprecation-warning branch February 16, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants