-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Improve the container platform API exposed to tests #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Improve the container platform API exposed to tests #1775
Conversation
* Allow for custom pulling commands for container images. * Respect the commands defined inside the container image.
|
@ChristianKniep please give your feedback |
kniec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweat, just some minor comments. I reckon that the pull_command is a bandaid until a more sustainable way forward is found. Might be that skopeo is the ultimate swiss army knife for downloading and transforming image. @vrothberg
Valentin might also have an opinion about adding podman here... :)
Thanks for pulling me in. Skopeo is super powerful and light weight. Podman, on the other hand, has Python bindings: https://github.com/containers/podman-py |
Codecov Report
@@ Coverage Diff @@
## master #1775 +/- ##
==========================================
+ Coverage 87.60% 87.62% +0.02%
==========================================
Files 49 49
Lines 7940 7954 +14
==========================================
+ Hits 6956 6970 +14
Misses 984 984
Continue to review full report at Codecov.
|
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-03-04 13:54:17 UTC |
|
@kniec the PR is more or less ready. I have made various changed taking into account your comments. I have also expanded the tutorial for containers to include Sarus. |
|
Thanks for the effort - I was busy this week, but I'll carve out some time in the next couple of days to go through it. |
workdirandcommandsfields.commandfield.Fixes #1736
workdirandcommandfields