Skip to content

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Feb 15, 2021

  • Respect the entrypoint and command defined inside the container image.
  • Deprecate workdir and commands fields.
  • Introduce the command field.
  • Allow to skip pulling of the container image from a container registry.
  • Expand container platform tutorial example.

Fixes #1736

  • Need to change also the documentation
  • Change the tutorial example
  • Add a tutorial example for making files available outside of the container
  • Deprecate the workdir and command fields

* Allow for custom pulling commands for container images.

* Respect the commands defined inside the container image.
@teojgo teojgo requested review from rsarm and vkarak February 15, 2021 16:23
@teojgo teojgo self-assigned this Feb 15, 2021
@teojgo teojgo added this to the ReFrame 3.4.2 milestone Feb 15, 2021
@teojgo
Copy link
Contributor Author

teojgo commented Feb 15, 2021

@ChristianKniep please give your feedback

@vkarak vkarak changed the title [enhancement] Improve the implementation of Container Platforms [feat] Improve the implementation of Container Platforms Feb 15, 2021
Copy link

@kniec kniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweat, just some minor comments. I reckon that the pull_command is a bandaid until a more sustainable way forward is found. Might be that skopeo is the ultimate swiss army knife for downloading and transforming image. @vrothberg
Valentin might also have an opinion about adding podman here... :)

@vrothberg
Copy link

Sweat, just some minor comments. I reckon that the pull_command is a bandaid until a more sustainable way forward is found. Might be that skopeo is the ultimate swiss army knife for downloading and transforming image. @vrothberg
Valentin might also have an opinion about adding podman here... :)

Thanks for pulling me in. Skopeo is super powerful and light weight. Podman, on the other hand, has Python bindings: https://github.com/containers/podman-py

@teojgo teojgo marked this pull request as draft February 17, 2021 16:47
@codecov-io
Copy link

codecov-io commented Feb 17, 2021

Codecov Report

Merging #1775 (be72092) into master (35c3020) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
+ Coverage   87.60%   87.62%   +0.02%     
==========================================
  Files          49       49              
  Lines        7940     7954      +14     
==========================================
+ Hits         6956     6970      +14     
  Misses        984      984              
Impacted Files Coverage Δ
reframe/core/containers.py 97.97% <100.00%> (+0.33%) ⬆️
reframe/core/pipeline.py 91.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c3020...be72092. Read the comment docs.

@vkarak vkarak modified the milestones: ReFrame 3.4.2, ReFrame 3.5.0 Feb 18, 2021
@teojgo teojgo marked this pull request as ready for review February 23, 2021 16:10
@pep8speaks
Copy link

pep8speaks commented Feb 25, 2021

Hello @teojgo, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-03-04 13:54:17 UTC

@teojgo
Copy link
Contributor Author

teojgo commented Feb 25, 2021

@kniec the PR is more or less ready. I have made various changed taking into account your comments. I have also expanded the tutorial for containers to include Sarus.

@kniec
Copy link

kniec commented Feb 25, 2021

Thanks for the effort - I was busy this week, but I'll carve out some time in the next couple of days to go through it.

@vkarak vkarak changed the title [feat] Improve the implementation of Container Platforms [feat] Improve the API of container platform backends Mar 4, 2021
@vkarak vkarak changed the title [feat] Improve the API of container platform backends [feat] Improve the container platform API exposed to tests Mar 4, 2021
@vkarak vkarak merged commit 027af16 into reframe-hpc:master Mar 4, 2021
@teojgo teojgo deleted the enhancement/container_platforms branch May 21, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Container execution w/ SARUS

6 participants