[test] Adapt environ regression tests to Eiger #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
requested changes
Feb 17, 2021
Contributor
Author
|
@ekouts They are more or less the same yes. I have put them in two different classes to be more explicit since the systems are of different nature. Also some of the modules of dom/daint don't exist on eiger and vice-versa. |
Codecov Report
@@ Coverage Diff @@
## master #1781 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 49 49
Lines 7919 7919
=======================================
Hits 6935 6935
Misses 984 984 Continue to review full report at Codecov.
|
vkarak
requested changes
Feb 17, 2021
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I am refactoring a bit this test.
vkarak
reviewed
Feb 17, 2021
vkarak
reviewed
Feb 18, 2021
Contributor
Author
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-02-22 09:07:33 UTC |
added 2 commits
February 18, 2021 17:49
vkarak
requested changes
Feb 18, 2021
ekouts
approved these changes
Feb 22, 2021
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.