[bugfix] Make attrs() utility function pass when an AttributeError is raised
#1802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
LoggerAdapterclass calls theattrsmethod fromreframe/utility/__init__.pyit retrieves the values of the data descriptors from an object.With the recent addition of the
variablebuilt-in, variables can be set asrequired(undefined), which means that a call togetattron these variables will raise anAttributeError. When any of these required variables is not set whenLoggerAdapterclass attempts to fetch all the descriptors from a test, this raises a very uglyAttributeError.For this reason, this
attrsfunction from utility must pass if its call togetattrraises anAttributeError.The unit test has also been changed accordingly.