-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Add a new prepare_cmds partition configuration parameter which allows to emit commands before loading any environment
#1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
teojgo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wil also need a unittest for this.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this PR is correct in its principle. These commands are partition specific and not test-specific. I don't think we should anything to the test API. Instead, these commands must be part of the configuration of the partition. This is what I understand from the issue: every script submitted to that partition needs to have a module purge.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good. I have a suggestion about the name of the option and we still need the following:
- A unit test or adapt
test_prepare - Documentation (both in the configuration reference and here (we need to update the script template).
|
@teojgo I think you are correct here. We should use it also for the build scripts, since for the moment we say that we submit to the same partition, so users would expect to see that in the build scripts, too, since they submit in the same partition. |
Yes for the moment it is used for both. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
prepare_cmds partition configuration parameter which allows to emit commands before loading any environment
|
@branfosj With this feature you will now be able to define your partition as follows: {
'name': 'mypart',
'scheduler': 'slurm',
'launcher': 'srun',
'prepare_cmds': ['module purge'],
'modules': ['bluebear']
}The |
|
Thanks |
Closes #1734